Skip to content

Commit

Permalink
chore(actor) Remove old actor columns
Browse files Browse the repository at this point in the history
Remove now unused actor columns from rule, alertrule, team,
grouphistory. These columns were removed from django state
in #69784, #69873, #69976, #70090

Refs HC-1178
  • Loading branch information
markstory committed May 8, 2024
1 parent 9fc6f1d commit 94d5f87
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 1 deletion.
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ feedback: 0004_index_together
hybridcloud: 0016_add_control_cacheversion
nodestore: 0002_nodestore_no_dictfield
replays: 0004_index_together
sentry: 0717_query_subscription_timebox
sentry: 0718_remove_actor_columns
social_auth: 0002_default_auto_field
53 changes: 53 additions & 0 deletions src/sentry/migrations/0718_remove_actor_columns.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# Generated by Django 5.0.4 on 2024-05-08 21:10

from django.db import migrations

from sentry.new_migrations.migrations import CheckedMigration


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production.
# This should only be used for operations where it's safe to run the migration after your
# code has deployed. So this should not be used for most operations that alter the schema
# of a table.
# Here are some things that make sense to mark as post deployment:
# - Large data migrations. Typically we want these to be run manually so that they can be
# monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# run this outside deployments so that we don't block them. Note that while adding an index
# is a schema change, it's completely safe to run the operation after the code has deployed.
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment

is_post_deployment = False

dependencies = [
("sentry", "0717_query_subscription_timebox"),
]

operations = [
migrations.SeparateDatabaseAndState(
state_operations=[],
database_operations=[
migrations.RunSQL(
sql="ALTER TABLE sentry_team DROP COLUMN actor_id",
reverse_sql="ALTER TABLE sentry_team ADD COLUMN actor_id BIGINT NULL",
hints={"tables": ["sentry_team"]},
),
migrations.RunSQL(
sql="ALTER TABLE sentry_rule DROP COLUMN owner_id",
reverse_sql="ALTER TABLE sentry_rule ADD COLUMN owner_id BIGINT NULL",
hints={"tables": ["sentry_rule"]},
),
migrations.RunSQL(
sql="ALTER TABLE sentry_alertrule DROP COLUMN owner_id",
reverse_sql="ALTER TABLE sentry_alertrule ADD COLUMN owner_id BIGINT NULL",
hints={"tables": ["sentry_alertrule"]},
),
migrations.RunSQL(
sql="ALTER TABLE sentry_grouphistory DROP COLUMN actor_id",
reverse_sql="ALTER TABLE sentry_grouphistory ADD COLUMN actor_id BIGINT NULL",
hints={"tables": ["sentry_grouphistory"]},
),
],
)
]

0 comments on commit 94d5f87

Please sign in to comment.