Skip to content

Commit

Permalink
ref(crons): Correct test_check_timeout large id usage (#79732)
Browse files Browse the repository at this point in the history
The large ID is meant to be set for the MonitorEnvironment not the
MonitorCheckIn like it was here.
  • Loading branch information
evanpurkhiser authored Oct 25, 2024
1 parent e44ad64 commit 6c0f21f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/sentry/monitors/clock_tasks/test_check_timeout.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ def test_timeout(self, mock_produce_task, mock_mark_failed):
},
)
monitor_environment = MonitorEnvironment.objects.create(
# XXX(epurkhiser): Arbitrarily large id to make sure we can
# correctly use the monitor_environment.id as the partition key
id=62702371781194950,
monitor=monitor,
environment_id=self.environment.id,
last_checkin=ts,
Expand All @@ -51,9 +54,6 @@ def test_timeout(self, mock_produce_task, mock_mark_failed):
)
# Checkin will timeout in 30 minutes
checkin = MonitorCheckIn.objects.create(
# XXX(epurkhiser): Arbitrarily large id to make sure we can
# correctly use the monitor_environment.id as the partition key
id=62702371781194950,
monitor=monitor,
monitor_environment=monitor_environment,
project_id=project.id,
Expand Down

0 comments on commit 6c0f21f

Please sign in to comment.