Skip to content

Commit

Permalink
fix(replays): don't overfetch url (#58012)
Browse files Browse the repository at this point in the history
since we deleted our `StringWalker` / displaying URLs in the
`ReplayCell`, we no longer need to fetch URLs
  • Loading branch information
michellewzhang authored Oct 12, 2023
1 parent 019554e commit 600b66f
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion fixtures/js-stubs/replayList.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export function ReplayList(
},
project_id: '2',
started_at: new Date('2022-09-15T06:50:03+00:00'),
urls: [],
user: {
display_name: 'testDisplayName',
email: '',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ describe('GroupReplays', () => {
'os',
'project_id',
'started_at',
'urls',
'user',
],
per_page: 50,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export default function ExampleReplaysList({
'finished_at',
'is_archived',
'started_at',
'urls',
],
projects: [projectId],
query: selectorQuery,
Expand Down
2 changes: 0 additions & 2 deletions static/app/views/replays/types.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ export const REPLAY_LIST_FIELDS = [
'os.version',
'project_id',
'started_at',
'urls',
'user',
];

Expand All @@ -143,7 +142,6 @@ export type ReplayListRecord = Pick<
| 'os'
| 'project_id'
| 'started_at'
| 'urls'
| 'user'
>;

Expand Down

0 comments on commit 600b66f

Please sign in to comment.