ref: fix typing for organization_teams (#79750)

getsentry · Oct 25, 2024 · 5ff9706 · 5ff9706
1 parent c2e7b01
commit 5ff9706
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -155,7 +155,6 @@ module = [
     "sentry.api.endpoints.organization_search_details",
     "sentry.api.endpoints.organization_sessions",
     "sentry.api.endpoints.organization_stats",
-    "sentry.api.endpoints.organization_teams",
     "sentry.api.endpoints.project_index",
     "sentry.api.endpoints.project_ownership",
     "sentry.api.endpoints.project_release_files",

diff --git a/src/sentry/api/endpoints/organization_teams.py b/src/sentry/api/endpoints/organization_teams.py
@@ -131,16 +131,18 @@ def get(self, request: Request, organization) -> Response:
                         )
 
                 elif key == "query":
-                    value = " ".join(value)
-                    queryset = queryset.filter(Q(name__icontains=value) | Q(slug__icontains=value))
+                    joined_value = " ".join(value)
+                    queryset = queryset.filter(
+                        Q(name__icontains=joined_value) | Q(slug__icontains=joined_value)
+                    )
                 elif key == "slug":
                     queryset = queryset.filter(slug__in=value)
                 elif key == "id":
                     try:
-                        value = [int(item) for item in value]
+                        int_values = [int(item) for item in value]
                     except ValueError:
                         raise ParseError(detail="Invalid id value")
-                    queryset = queryset.filter(id__in=value)
+                    queryset = queryset.filter(id__in=int_values)
                 else:
                     queryset = queryset.none()