Skip to content

Commit

Permalink
fix(trace-view): Incorrect indicator scores (#81991)
Browse files Browse the repository at this point in the history
In a previous PR, the score set on the indicator is already multiplied
by 100 beforehand, so the multiplication in here is incorrect and is
inflating the score value.

---------

Co-authored-by: Jonas <[email protected]>
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Dec 12, 2024
1 parent 338ee0d commit 387b900
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions static/app/views/performance/newTraceDetails/trace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -401,10 +401,10 @@ export function Trace({
>
{trace.indicators.length > 0
? trace.indicators.map((indicator, i) => {
const score = indicator.score
? Math.round(indicator.score * 100)
: undefined;
const status = score ? STATUS_TEXT[scoreToStatus(score)] : 'none';
const status =
indicator.score === undefined
? 'none'
: STATUS_TEXT[scoreToStatus(indicator.score)];

return (
<div
Expand Down

0 comments on commit 387b900

Please sign in to comment.