Skip to content

Commit

Permalink
c
Browse files Browse the repository at this point in the history
  • Loading branch information
Rachel Chen authored and Rachel Chen committed Dec 11, 2024
1 parent b186dea commit 3466380
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/sentry/utils/snuba_rpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def table_rpc(req: TraceItemTableRequest) -> TraceItemTableResponse:
resp = _make_rpc_request("EndpointTraceItemTable", "v1", req.meta.referrer, req)
response = TraceItemTableResponse()
response.ParseFromString(resp.data)
print("response_after_rpc", response)
return response


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1470,7 +1470,7 @@ def test_span_duration(self):
]
assert meta["dataset"] == self.dataset

@pytest.mark.xfail(reason="sampling_factor is not a queryable column yet")
# @pytest.mark.xfail(reason="sampling_factor is not a queryable column yet")
def test_average_sampling_rate(self):
spans = []
spans.append(
Expand Down Expand Up @@ -1512,7 +1512,7 @@ def test_average_sampling_rate(self):
data = response.data["data"]
confidence = response.data["confidence"]
assert len(data) == 1
assert data[0]["avg_sample(sampling_rate)"] == pytest.approx(0.475)
assert data[0]["avg_sample(sampling_rate)"] == 0.475
assert data[0]["min(sampling_rate)"] == pytest.approx(0.1)
assert data[0]["count_sample()"] == 2
assert data[0]["count()"] == 11
Expand Down

0 comments on commit 3466380

Please sign in to comment.