-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(issues): Expand participants/viewers in issue sidebar (#58098)
- Loading branch information
Showing
5 changed files
with
359 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,13 @@ | ||
| import {Tags} from 'sentry-fixture/tags'; | ||
|
|
||
| import {initializeOrg} from 'sentry-test/initializeOrg'; | ||
| import {render, screen, waitFor, within} from 'sentry-test/reactTestingLibrary'; | ||
| import { | ||
| render, | ||
| screen, | ||
| userEvent, | ||
| waitFor, | ||
| within, | ||
| } from 'sentry-test/reactTestingLibrary'; | ||
|
|
||
| import MemberListStore from 'sentry/stores/memberListStore'; | ||
|
|
||
|
|
@@ -208,8 +214,59 @@ describe('GroupSidebar', function () { | |
| /> | ||
| ); | ||
|
|
||
| expect(await screen.findByText('Participants (2)')).toBeInTheDocument(); | ||
| expect(screen.getByText('Viewers (2)')).toBeInTheDocument(); | ||
| expect( | ||
| await screen.findByRole('heading', {name: 'Participants (2)'}) | ||
| ).toBeInTheDocument(); | ||
| expect(screen.getByRole('heading', {name: 'Viewers (2)'})).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('expands participants and viewers', async () => { | ||
| const org = { | ||
| ...organization, | ||
| features: ['participants-purge'], | ||
| }; | ||
| const teams = [{...TestStubs.Team(), type: 'team'}]; | ||
| const users = [ | ||
| TestStubs.User({ | ||
| id: '2', | ||
| name: 'John Smith', | ||
| email: '[email protected]', | ||
| type: 'user', | ||
| }), | ||
| TestStubs.User({ | ||
| id: '3', | ||
| name: 'Sohn Jmith', | ||
| email: '[email protected]', | ||
| type: 'user', | ||
| }), | ||
| ]; | ||
| render( | ||
| <GroupSidebar | ||
| group={{ | ||
| ...group, | ||
| participants: [...teams, ...users], | ||
| seenBy: users, | ||
| }} | ||
| project={project} | ||
| organization={org} | ||
| event={TestStubs.Event()} | ||
| environments={[]} | ||
| />, | ||
| { | ||
| organization: org, | ||
| } | ||
| ); | ||
|
|
||
| expect( | ||
| await screen.findByRole('heading', {name: 'Participants (1 Team, 2 Individuals)'}) | ||
| ).toBeInTheDocument(); | ||
| expect(screen.queryByText('#team-slug')).not.toBeInTheDocument(); | ||
|
|
||
| await userEvent.click( | ||
| screen.getAllByRole('button', {name: 'Expand Participants'})[0] | ||
| ); | ||
|
|
||
| await waitFor(() => expect(screen.getByText('#team-slug')).toBeVisible()); | ||
| }); | ||
|
|
||
| describe('displays mobile tags when issue platform is mobile', function () { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import {Team} from 'sentry-fixture/team'; | ||
| import {User} from 'sentry-fixture/user'; | ||
|
|
||
| import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary'; | ||
|
|
||
| import {ParticipantList} from './participantList'; | ||
|
|
||
| describe('ParticipantList', () => { | ||
| const users = [ | ||
| User({id: '1', name: 'John Doe', email: '[email protected]'}), | ||
| User({id: '2', name: 'Jane Doe', email: '[email protected]'}), | ||
| ]; | ||
|
|
||
| const teams = [ | ||
| Team({id: '1', slug: 'team-1', memberCount: 3}), | ||
| Team({id: '2', slug: 'team-2', memberCount: 5}), | ||
| ]; | ||
|
|
||
| it('expands and collapses the list when clicked', async () => { | ||
| render( | ||
| <ParticipantList teams={teams} users={users} description="Participants"> | ||
| Click Me | ||
| </ParticipantList> | ||
| ); | ||
| expect(screen.queryByText('#team-1')).not.toBeInTheDocument(); | ||
| await userEvent.click(screen.getByText('Click Me')); | ||
| await waitFor(() => expect(screen.getByText('#team-1')).toBeVisible()); | ||
|
|
||
| expect(screen.getByText('Teams (2)')).toBeInTheDocument(); | ||
| expect(screen.getByText('Individuals (2)')).toBeInTheDocument(); | ||
|
|
||
| await userEvent.click(screen.getByText('Click Me')); | ||
| await waitFor(() => expect(screen.getByText('#team-1')).not.toBeVisible()); | ||
| }); | ||
|
|
||
| it('does not display section headers when there is only users or teams', async () => { | ||
| render( | ||
| <ParticipantList teams={[]} users={users} description="Participants"> | ||
| Click Me | ||
| </ParticipantList> | ||
| ); | ||
| await userEvent.click(screen.getByRole('button', {name: 'Click Me'})); | ||
| await waitFor(() => expect(screen.getByText('John Doe')).toBeVisible()); | ||
|
|
||
| expect(screen.queryByText('Individuals (2)')).not.toBeInTheDocument(); | ||
| }); | ||
| }); |
Oops, something went wrong.