Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nuxt): Add deployment-platform flow with links to docs #747
feat(nuxt): Add deployment-platform flow with links to docs #747
Changes from 3 commits
a6edeea
74209a8
a9f1fe2
86ccc64
31fa5d9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 107 in e2e-tests/tests/nuxt-3.test.ts
GitHub Actions / Lint
Check warning on line 111 in e2e-tests/tests/nuxt-3.test.ts
GitHub Actions / Lint
Check warning on line 115 in e2e-tests/tests/nuxt-3.test.ts
GitHub Actions / Lint
Check warning on line 120 in e2e-tests/tests/nuxt-3.test.ts
GitHub Actions / Lint
Check warning on line 127 in e2e-tests/tests/nuxt-3.test.ts
GitHub Actions / Lint
Check warning on line 142 in e2e-tests/tests/nuxt-3.test.ts
GitHub Actions / Lint
Check warning on line 166 in e2e-tests/tests/nuxt-3.test.ts
GitHub Actions / Lint
Check warning on line 182 in e2e-tests/tests/nuxt-3.test.ts
GitHub Actions / Lint
Check warning on line 186 in e2e-tests/tests/nuxt-3.test.ts
GitHub Actions / Lint
Check warning on line 106 in e2e-tests/tests/nuxt-4.test.ts
GitHub Actions / Lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: given that this is a pretty crucial step, I was thinking that we could make this a step that users have to confirm instead of showing this in the outro message.
So basically, print this message and make them confirm the step with an "Ok, I got it" or so. There's similar precedence for something like this in our source map wizard.
I'll leave this up to you though, so feel free to go with whatever you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good idea! What if we (also?) opened up the docs for them with that link since it's pretty crucial that they read the info on there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lms24 @s1gr1d how about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! I think it's most important to have this one extra step so that people actually read what the wizard tells them, before the outro message is printed. Asking about opening docs achieves this well. Thanks!