feat(flutter): Add Flutter support #735
Open
+4,884
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
|
@buenaflor Ready for the first review/feedback round :) |
Lms24
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Hey, leaving a first pass review for general wizard recommendations. This is not technical as I have very little to no context around Flutter.
- Ideally, we can make the SDK features selectable from the start as we've done recently with the JS-SDK wizards. See Make Sentry features selectable in wizard #558
- Great to see some tests for this flow! :) I recommend adding an e2e test app as well as this proved quite useful for our other wizards.
Feel free to disregard my advice as I'll happily leave the final call to the mobile team. Don't want to block you, just share some recommendations :)
smeubank
reviewed
Dec 12, 2024
…o feat/flutter-support # Conflicts: # CHANGELOG.md
|
@bruno-garcia We have added replay as an option, but we are not sure if we should, as it is still beta on Flutter. Do you have any guidance/thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main.dartwith import, sentry setup and sample snippetpubspec.yamlwith sentry_flutter dependency and plugin to upload debug symbols and source mapsCloses getsentry/sentry-dart#2424
Relates to #558