Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): Add nuxt wizard #719

Merged
merged 9 commits into from
Nov 27, 2024
Merged

feat(nuxt): Add nuxt wizard #719

merged 9 commits into from
Nov 27, 2024

Conversation

andreiborza
Copy link
Member

@andreiborza andreiborza commented Nov 25, 2024

Closes: #705

@andreiborza andreiborza requested a review from lforst November 25, 2024 12:24
Copy link

github-actions bot commented Nov 25, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 430cba1

* feat(nuxt): Add Nuxt menu option and install SDK

* Mark sentry dot env file in cyan color
…r config files (#713)

* feat(nuxt): Add sdk module to nuxt config and create client and server config files

* Log snippets when user denies overwriting their configs
* feat(nuxt): Add nuxt-3 e2e tests

* Add nuxt-3 e2e tests

* Add describe level

* Add nuxt-4 e2e test app

* Add nuxt 4 e2e test app

* Remove leaking test helper
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the wizard in an OSS nuxt project and it worked well! The steps seem fine to me, wording is great! :shipit:

)} failed, please add the following settings:`,
);
// eslint-disable-next-line no-console
console.log(`\n\n${getNuxtModuleFallbackTemplate(options)}\n\n`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l (feel free to disregard if N/A): We have a diff-like helper function for displaying code snippets: makeCodeSnippet in clack-utils.ts. Might be useful here but I'll let you make the call if it's necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll disregard for now to get this out, but will revisit.

src/nuxt/sdk-setup.ts Outdated Show resolved Hide resolved
Co-authored-by: Lukas Stracke <[email protected]>
@andreiborza andreiborza merged commit 1bde610 into master Nov 27, 2024
16 checks passed
@andreiborza andreiborza deleted the ab/nuxt-wizard branch November 27, 2024 11:13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreiborza, this test app is added here as a submodule. I think that's why the Nuxt tests are broken on master.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice catch @onurtemizkan, I opened up a pr to fix it: #742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Nuxt SDK Setup
4 participants