Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): Add example page/component creation and final messaging #717

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

andreiborza
Copy link
Member

@andreiborza andreiborza commented Nov 21, 2024

Sets up either an example page or an example vue component depending on whether the user has <NuxtPage /> in their app.vue.

For users that have an app.vue but no pages route directory, adding an example page would probably be confusing as it will not visibly render anything unless app.vue has a <NuxtPage/> component.

Since we cannot reliably place ourselves, I opted to create an example component instead for such cases.

#skip-changelog

Closes: #709

@andreiborza andreiborza requested review from lforst and Lms24 November 21, 2024 13:54
Copy link

github-actions bot commented Nov 21, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 36e43da

Base automatically changed from ab/nuxt-client-server-setup to ab/nuxt-wizard November 22, 2024 13:58
@andreiborza andreiborza merged commit be94c4b into ab/nuxt-wizard Nov 22, 2024
13 checks passed
@andreiborza andreiborza deleted the ab/nuxt-example-page branch November 22, 2024 14:11
andreiborza added a commit that referenced this pull request Nov 27, 2024
* feat(nuxt): Add Nuxt menu option and install SDK (#711)

* feat(nuxt): Add Nuxt menu option and install SDK

* Mark sentry dot env file in cyan color

* feat(nuxt): Add sdk module to nuxt config and create client and server config files (#713)

* feat(nuxt): Add sdk module to nuxt config and create client and server config files

* Log snippets when user denies overwriting their configs

* feat(nuxt): Add example page/component creation and final messaging (#717)

* feat(nuxt): Add nuxt 3 and 4 e2e test apps (#718)

* feat(nuxt): Add nuxt-3 e2e tests

* Add nuxt-3 e2e tests

* Add describe level

* Add nuxt-4 e2e test app

* Add nuxt 4 e2e test app

* Remove leaking test helper

* change client source map to hidden

* add scoped styles

* Add fallback in case magicast can't parse/modify the nuxt config

* change min version to 3.7.0

* Update src/nuxt/sdk-setup.ts

Co-authored-by: Lukas Stracke <[email protected]>

---------

Co-authored-by: s1gr1d <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants