Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs,sveltekit): Replace deprecated Sentry API calls in example page templates #520

Merged
merged 5 commits into from
Dec 22, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 20, 2023

fixes #519

We had configureScope and startTransaction calls in the example page templates. Given we've deprecated the former and will soon deprecate the other, this PR updates the templates to use the new startSpan API instead.

Also shows how much simpler the new API makes this example.

@Lms24 Lms24 force-pushed the lms/fix-replace-deprecated-functions branch from 14c6c1a to 190a111 Compare December 20, 2023 17:28
@Lms24 Lms24 marked this pull request as ready for review December 22, 2023 10:19
@Lms24 Lms24 requested a review from lforst December 22, 2023 10:19
src/nextjs/templates.ts Outdated Show resolved Hide resolved
@Lms24 Lms24 merged commit 9c70a94 into master Dec 22, 2023
10 checks passed
@Lms24 Lms24 deleted the lms/fix-replace-deprecated-functions branch December 22, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated configureScope is used in a few templates
2 participants