Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reactnative): Use Xcode scripts bundled with Sentry RN SDK #499

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

krystofwoldrich
Copy link
Member

Since RN SDK 5.11.0 we ship Xcode scripts which replace directly patch code into the build phases of the RN Xcode project.

This PR updates the wizard to detect the SDK version which shipps with the scripts and use them to create the Xcode build phases.

Copy link

github-actions bot commented Nov 16, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ca2f551

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from general wizard perspective. Can't say much about the correctness for RN though.

@krystofwoldrich krystofwoldrich merged commit 5982df3 into master Nov 17, 2023
10 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-rn-xcode-bundled-scripts branch November 17, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants