feat(nextjs): Add instructions for custom _error page #496
Conversation
|
| fs | ||
| .readFileSync( | ||
| path.join(process.cwd(), ...pagesLocation, underscoreErrorPageFile), | ||
| 'utf8', | ||
| ) | ||
| .includes('getInitialProps') |
There was a problem hiding this comment.
l: This could lead to a false positive for commented out code but I guess it's fine
There was a problem hiding this comment.
I saw this more as a heuristic of "are people aware of getInitialProps and what it does". If they have it commented out somewhere, they're likely aware of it's existence and can google on how to use it. If it's not there at all people might not know it and then we need to have a little bit more hand-holding.
| console.log( | ||
| getFullUnderscoreErrorCopyPasteSnippet( | ||
| underscoreErrorPageFile === '_error.ts' || | ||
| underscoreErrorPageFile === '_error.tsx', | ||
| ), | ||
| ); |
| ); | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.log(getSimpleUnderscoreErrorCopyPasteSnippet()); |
There was a problem hiding this comment.
l/m: Should we use the copy/paste instruction helper function from clack-utils.ts instead?
There was a problem hiding this comment.
Oh, I forgot this existed!
There was a problem hiding this comment.
Now that I look at it, I think I'd like to have a slightly different message than in the helper. Are you okay with me leaving it like this or should I make adjustments?
There was a problem hiding this comment.
Sure, sounds good. Just wanted to make sure we use it it's applicable.
Following getsentry/sentry-docs#8479 we want the wizard to provide you instructions on how to instrument React rendering errors.