Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): Fix Remix version and TS checks. #464

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

onurtemizkan
Copy link
Collaborator

There was a bug caused by wrong parameter orders of isV2 and isTS on server instrumentation step.

Also improved Remix version checks, making them similar to svelte and next wizards.

@onurtemizkan onurtemizkan requested a review from Lms24 September 19, 2023 10:35
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Lms24 Lms24 merged commit 9cd16e5 into master Sep 19, 2023
9 checks passed
@Lms24 Lms24 deleted the onur/remix-fixes branch September 19, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants