Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(android): Show link to issues page after setup is complete #448

Merged
merged 2 commits into from
Sep 13, 2023
Merged

enh(android): Show link to issues page after setup is complete #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fea5e44
enh(android): Show link to issues page after setup is complete
romtsn Sep 12, 2023
76d1ac3
Changelog
romtsn Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

- enh(android): Show link to issues page after setup is complete (#448)

## 3.12.0

- feat(sourcemaps): Automatically insert Sentry Webpack plugin (#432)
Expand Down
13 changes: 8 additions & 5 deletions src/android/android-wizard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,8 @@ async function runAndroidWizardWithTelemetry(
gradle.selectAppFile(buildGradleFiles),
);

const { selectedProject, authToken } = await getOrAskForProjectData(
options,
'android',
);
const { selectedProject, selfHosted, sentryUrl, authToken } =
await getOrAskForProjectData(options, 'android');

// ======== STEP 1. Add Sentry Gradle Plugin to build.gradle(.kts) ============
clack.log.step(
Expand Down Expand Up @@ -172,11 +170,16 @@ async function runAndroidWizardWithTelemetry(
);

// ======== OUTRO ========
const issuesPageLink = selfHosted
? `${sentryUrl}organizations/${selectedProject.organization.slug}/issues/?project=${selectedProject.id}`
: `https://${selectedProject.organization.slug}.sentry.io/issues/?project=${selectedProject.id}`;

clack.outro(`
${chalk.greenBright('Successfully installed the Sentry Android SDK!')}

${chalk.cyan(
'You can validate your setup by launching your application and checking Sentry issues page afterwards',
`You can validate your setup by launching your application and checking Sentry issues page afterwards
${issuesPageLink}`,
)}

Check out the SDK documentation for further configuration:
Expand Down