Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(wizard): sort projects in project-selection step #441

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

markushi
Copy link
Member

Small enhancement to show the list of projects in alphabetical order:
image

Ideally one could even type to search to filter the list, but the underlying clack.select doesn't seem to provide this functionality.

@markushi markushi requested a review from Lms24 September 12, 2023 08:05
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of this!

TLDR: Let's :shipit:

I'm wondering if it would make generally more sense to order in the backend but I think the challenge is that this list requires org/project ordering which might be too specific for doing it in the backend.
Furthermore, the in queries already prolong the retrieval enough, so throwing in another round of sorting might be more problematic anyway 🤔
Also, this is probably the fastest way to fix so let's go with it.

Ideally one could even type to search to filter the list, but the underlying clack.select doesn't seem to provide this functionality.

I agree - it'd be great to get this functionality. We previously already contributed the maxItems option. Maybe we could add this, too. I just don't think we (= frontend team) have the capacity for this at the moment.

This leaves us with the proposal in #357 which would move the project selection step entirely to the browser. Arguably, this would make project selection nicer UI-wise but it's more challenging and questionable how well we can pull it off with maintaining backwards-compatibility for self-hosted folks.

CHANGELOG.md Outdated Show resolved Hide resolved
@markushi markushi merged commit 72c8f11 into master Sep 12, 2023
9 checks passed
@markushi markushi deleted the enh/sort-project-list branch September 12, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants