Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Add support for unusual import statements #440

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

markushi
Copy link
Member

Sometimes injecting the sentry import statements fails due to imports like

import static a.b.c;
import x.y.z as D;
import a.b.*;

This PR adds support for that and some basic unit tests.

@markushi markushi requested review from romtsn and Lms24 September 11, 2023 15:04
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks 💯

@markushi markushi merged commit 4be7aff into master Sep 12, 2023
9 checks passed
@markushi markushi deleted the fix/android-java-kotlin-package-imports branch September 12, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants