Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Create necessary directories in app router #439

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

andreysam
Copy link
Contributor

fix #436

@Lms24 Lms24 requested a review from lforst September 12, 2023 08:56
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andreysam thanks for opening this PR! Can you please add a little more information in the PR description? I believe this is fixes an error if the directory we're trying to add our sample files doesn't yet exist, correct? Let's just make this clear for future readers in the description.

@andreysam
Copy link
Contributor Author

Hi @Lms24 NextJS app router has deeper folder structure than older router. Wizard wants to create correct files, but it fails when folder doesn't exist. This fix makes sure that necessary folders exist before creating page and API examples

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining!

@Lms24 Lms24 force-pushed the fix/nextjs-app-directories branch from a6021cb to b8d6eee Compare September 13, 2023 08:23
@Lms24 Lms24 changed the title fix(nextjs): create necessary directories in app router fix(nextjs): Create necessary directories in app router Sep 13, 2023
@Lms24 Lms24 merged commit 138143a into getsentry:master Sep 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installing in next js errors
2 participants