Skip to content

Commit

Permalink
ref(nuxt): Remove option to downgrade override nitropack
Browse files Browse the repository at this point in the history
  • Loading branch information
andreiborza committed Dec 16, 2024
1 parent cef7ce7 commit 43dddda
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 32 deletions.
15 changes: 1 addition & 14 deletions e2e-tests/tests/nuxt-3.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,25 +44,12 @@ async function runWizardOnNuxtProject(projectDir: string): Promise<void> {
'Please select your package manager.',
);

const nitropackOverridePrompted =
const nftOverridePrompted =
packageManagerPrompted &&
(await wizardInstance.sendStdinAndWaitForOutput(
// Selecting `yarn` as the package manager
[KEYS.DOWN, KEYS.ENTER],
// Do you want to install version 2.9.7 of nitropack and add an override to package.json?
'Do you want to add an override for nitropack version ~2.9.7?',
{
timeout: 240_000,
},
));

const nftOverridePrompted =
nitropackOverridePrompted &&
(await wizardInstance.sendStdinAndWaitForOutput(
// Selecting `yes` to downgrade nitropack
KEYS.ENTER,
'Do you want to add an override for @vercel/nft version ^0.27.4?',
// 'Do you want to install version',
{
timeout: 240_000,
},
Expand Down
15 changes: 1 addition & 14 deletions e2e-tests/tests/nuxt-4.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,25 +43,12 @@ async function runWizardOnNuxtProject(projectDir: string): Promise<void> {
'Please select your package manager.',
);

const nitropackOverridePrompted =
const nftOverridePrompted =
packageManagerPrompted &&
(await wizardInstance.sendStdinAndWaitForOutput(
// Selecting `yarn` as the package manager
[KEYS.DOWN, KEYS.ENTER],
// Do you want to install version 2.9.7 of nitropack and add an override to package.json?
'Do you want to add an override for nitropack version ~2.9.7?',
{
timeout: 240_000,
},
));

const nftOverridePrompted =
nitropackOverridePrompted &&
(await wizardInstance.sendStdinAndWaitForOutput(
// Selecting `yes` to downgrade nitropack
KEYS.ENTER,
'Do you want to add an override for @vercel/nft version ^0.27.4?',
// 'Do you want to install version',
{
timeout: 240_000,
},
Expand Down
4 changes: 0 additions & 4 deletions src/nuxt/sdk-setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,6 @@ export async function addNuxtOverrides(
const isPNPM = PNPM.detect();

const overrides = [
{
pkgName: 'nitropack',
pkgVersion: '~2.9.7',
},
{
pkgName: '@vercel/nft',
pkgVersion: '^0.27.4',
Expand Down

0 comments on commit 43dddda

Please sign in to comment.