feat(reactnative): Make pod install step optional (#501)

getsentry · Nov 17, 2023 · 225e676 · 225e676
1 parent 6fa3bde
commit 225e676
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- feat(reactnative): Make `pod install` step optional (#501)
+
 ## 3.16.5
 
 - feat(remix): Add Vite support (#495)

diff --git a/src/apple/cocoapod.ts b/src/apple/cocoapod.ts
@@ -56,8 +56,10 @@ export async function podInstall(dir = '.') {
     await bash.execute(`cd ${dir} && pod repo update`);
     await bash.execute(`cd ${dir} && pod install --silent`);
     installSpinner.stop('Pods installed.');
+    Sentry.setTag('pods-installed', true);
   } catch (e) {
     installSpinner.stop('Failed to install pods.');
+    Sentry.setTag('pods-installed', false);
     clack.log.error(
       `${chalk.red(
         'Encountered the following error during pods installation:',

diff --git a/src/react-native/react-native-wizard.ts b/src/react-native/react-native-wizard.ts
@@ -7,6 +7,7 @@ import * as path from 'path';
 import * as process from 'process';
 import {
   CliSetupConfigContent,
+  abortIfCancelled,
   addSentryCliConfig,
   confirmContinueIfNoOrDirtyGitRepo,
   confirmContinueIfPackageVersionNotSupported,
@@ -248,9 +249,8 @@ async function patchXcodeFiles(config: RNCliSetupConfigContent) {
     gitignore: false,
   });
 
-  if (platform() === 'darwin') {
+  if (platform() === 'darwin' && (await confirmPodInstall())) {
     await traceStep('pod-install', () => podInstall('ios'));
-    Sentry.setTag('pods-installed', true);
   }
 
   const xcodeProjectPath = traceStep('find-xcode-project', () =>
@@ -374,3 +374,24 @@ async function patchAndroidFiles(config: RNCliSetupConfigContent) {
     chalk.green(`Android ${chalk.cyan('app/build.gradle')} saved.`),
   );
 }
+
+async function confirmPodInstall(): Promise<boolean> {
+  return traceStep('confirm-pod-install', async () => {
+    const continueWithPodInstall = await abortIfCancelled(
+      clack.select({
+        message: 'Do you want to run `pod install` now?',
+        options: [
+          {
+            value: true,
+            label: 'Yes',
+            hint: 'Recommended for smaller projects, this might take several minutes',
+          },
+          { value: false, label: `No, I'll do it later` },
+        ],
+        initialValue: true,
+      }),
+    );
+    Sentry.setTag('continue-with-pod-install', continueWithPodInstall);
+    return continueWithPodInstall;
+  });
+}