Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecates @sentry/utils #4352

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Deprecates @sentry/utils #4352

merged 9 commits into from
Dec 12, 2024

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Dec 9, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Based on JavaScript SDK to v8.41.0 bump

💡 Motivation and Context

Fixes #4327

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

This was referenced Dec 9, 2024
Merged
Merged
@antonis antonis marked this pull request as ready for review December 9, 2024 12:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 372.11 ms 417.00 ms 44.89 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c2a4e9b+dirty 392.94 ms 474.55 ms 81.61 ms
7fd512a+dirty 439.69 ms 503.71 ms 64.01 ms
e1ea4a8+dirty 451.98 ms 497.58 ms 45.60 ms
b8ff156+dirty 386.72 ms 398.18 ms 11.46 ms
d8668ce+dirty 372.43 ms 403.84 ms 31.41 ms
12427f4+dirty 379.48 ms 400.92 ms 21.44 ms
5446992+dirty 371.61 ms 390.00 ms 18.39 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
ddc0552+dirty 405.80 ms 480.00 ms 74.20 ms
ed3d77e+dirty 366.04 ms 411.33 ms 45.28 ms

App size

Revision Plain With Sentry Diff
c2a4e9b+dirty 7.15 MiB 8.34 MiB 1.19 MiB
7fd512a+dirty 7.15 MiB 8.35 MiB 1.21 MiB
e1ea4a8+dirty 7.15 MiB 8.35 MiB 1.20 MiB
b8ff156+dirty 7.15 MiB 8.37 MiB 1.22 MiB
d8668ce+dirty 7.15 MiB 8.35 MiB 1.20 MiB
12427f4+dirty 7.15 MiB 8.12 MiB 997.78 KiB
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
ddc0552+dirty 7.15 MiB 8.37 MiB 1.22 MiB
ed3d77e+dirty 7.15 MiB 8.35 MiB 1.21 MiB

Previous results on branch: antonis/deprecate-sentry-utils

Startup times

Revision Plain With Sentry Diff
6bdf19f+dirty 437.16 ms 502.02 ms 64.86 ms
f58f42d+dirty 314.76 ms 344.50 ms 29.74 ms

App size

Revision Plain With Sentry Diff
6bdf19f+dirty 7.15 MiB 8.37 MiB 1.22 MiB
f58f42d+dirty 7.15 MiB 8.37 MiB 1.22 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.04 ms 1218.94 ms 2.90 ms
Size 2.36 MiB 3.10 MiB 757.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d8668ce+dirty 1225.18 ms 1228.08 ms 2.90 ms
8de2810+dirty 1230.84 ms 1226.35 ms -4.49 ms
1332acb+dirty 1230.53 ms 1234.54 ms 4.01 ms
eb1e19f+dirty 1209.56 ms 1214.94 ms 5.38 ms
61310e1+dirty 1216.06 ms 1220.64 ms 4.58 ms
a989877+dirty 1228.56 ms 1227.71 ms -0.85 ms
1faf8e3+dirty 1214.87 ms 1222.83 ms 7.97 ms
75774ea+dirty 1231.33 ms 1243.39 ms 12.06 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
484813b+dirty 1222.45 ms 1220.79 ms -1.66 ms

App size

Revision Plain With Sentry Diff
d8668ce+dirty 2.36 MiB 3.08 MiB 737.08 KiB
8de2810+dirty 2.36 MiB 3.10 MiB 752.30 KiB
1332acb+dirty 2.36 MiB 3.11 MiB 759.86 KiB
eb1e19f+dirty 2.36 MiB 3.08 MiB 737.21 KiB
61310e1+dirty 2.36 MiB 3.10 MiB 757.92 KiB
a989877+dirty 2.36 MiB 3.10 MiB 752.40 KiB
1faf8e3+dirty 2.36 MiB 3.08 MiB 736.75 KiB
75774ea+dirty 2.36 MiB 3.10 MiB 757.87 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
484813b+dirty 2.36 MiB 3.08 MiB 734.18 KiB

Previous results on branch: antonis/deprecate-sentry-utils

Startup times

Revision Plain With Sentry Diff
6bdf19f+dirty 1225.87 ms 1230.91 ms 5.04 ms
f58f42d+dirty 1237.18 ms 1243.68 ms 6.50 ms

App size

Revision Plain With Sentry Diff
6bdf19f+dirty 2.36 MiB 3.10 MiB 757.45 KiB
f58f42d+dirty 2.36 MiB 3.10 MiB 757.40 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.27 ms 1229.81 ms 1.55 ms
Size 2.92 MiB 3.67 MiB 769.93 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d8668ce+dirty 1249.70 ms 1242.31 ms -7.39 ms
8de2810+dirty 1238.15 ms 1236.31 ms -1.84 ms
1332acb+dirty 1243.98 ms 1241.12 ms -2.86 ms
eb1e19f+dirty 1229.91 ms 1231.63 ms 1.71 ms
61310e1+dirty 1229.04 ms 1238.43 ms 9.39 ms
a989877+dirty 1222.90 ms 1219.89 ms -3.00 ms
1faf8e3+dirty 1223.38 ms 1220.56 ms -2.82 ms
75774ea+dirty 1235.23 ms 1235.02 ms -0.21 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
484813b+dirty 1225.07 ms 1221.00 ms -4.07 ms

App size

Revision Plain With Sentry Diff
d8668ce+dirty 2.92 MiB 3.64 MiB 742.99 KiB
8de2810+dirty 2.92 MiB 3.66 MiB 756.74 KiB
1332acb+dirty 2.92 MiB 3.67 MiB 772.45 KiB
eb1e19f+dirty 2.92 MiB 3.64 MiB 742.82 KiB
61310e1+dirty 2.92 MiB 3.66 MiB 762.99 KiB
a989877+dirty 2.92 MiB 3.66 MiB 757.66 KiB
1faf8e3+dirty 2.92 MiB 3.64 MiB 742.61 KiB
75774ea+dirty 2.92 MiB 3.66 MiB 763.01 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
484813b+dirty 2.92 MiB 3.64 MiB 740.56 KiB

Previous results on branch: antonis/deprecate-sentry-utils

Startup times

Revision Plain With Sentry Diff
6bdf19f+dirty 1242.51 ms 1241.74 ms -0.77 ms
f58f42d+dirty 1232.10 ms 1236.69 ms 4.59 ms

App size

Revision Plain With Sentry Diff
6bdf19f+dirty 2.92 MiB 3.67 MiB 769.98 KiB
f58f42d+dirty 2.92 MiB 3.67 MiB 770.03 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 458.20 ms 447.54 ms -10.66 ms
Size 17.74 MiB 20.08 MiB 2.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e22745e 462.66 ms 458.10 ms -4.56 ms
70e6261 482.65 ms 495.70 ms 13.05 ms
575f9da 415.26 ms 422.98 ms 7.72 ms
e5bc97b 438.96 ms 437.39 ms -1.57 ms
77680ec 482.22 ms 475.07 ms -7.16 ms
e1ea4a8 506.82 ms 510.48 ms 3.66 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
13f280b 486.16 ms 472.45 ms -13.71 ms
12427f4 393.69 ms 414.84 ms 21.14 ms
abb7058 370.27 ms 389.58 ms 19.31 ms

App size

Revision Plain With Sentry Diff
e22745e 17.74 MiB 20.08 MiB 2.34 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB
575f9da 17.73 MiB 19.83 MiB 2.10 MiB
e5bc97b 17.74 MiB 20.08 MiB 2.34 MiB
77680ec 17.74 MiB 20.08 MiB 2.34 MiB
e1ea4a8 17.74 MiB 20.08 MiB 2.34 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
13f280b 17.74 MiB 20.08 MiB 2.34 MiB
12427f4 17.73 MiB 19.85 MiB 2.12 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB

Previous results on branch: antonis/deprecate-sentry-utils

Startup times

Revision Plain With Sentry Diff
f58f42d 447.00 ms 451.80 ms 4.80 ms
6bdf19f 678.24 ms 668.57 ms -9.67 ms

App size

Revision Plain With Sentry Diff
f58f42d 17.74 MiB 20.08 MiB 2.35 MiB
6bdf19f 17.74 MiB 20.08 MiB 2.35 MiB

@antonis
Merge branch 'main' into antonis/bump-JavaScriptSDK-to-8.41.0
a1491be 
# Conflicts:
#	dev-packages/e2e-tests/package.json
#	samples/react-native-macos/package.json
#	yarn.lock
@antonis
Merge branch 'antonis/bump-JavaScriptSDK-to-8.41.0' into antonis/depr…
8e3c120 
…ecate-sentry-utils

# Conflicts:
#	dev-packages/e2e-tests/package.json
#	yarn.lock
@antonis
Reverts sentry/utils dependency removal
44a2b3f
lucas-zimerman
lucas-zimerman approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from antonis/bump-JavaScriptSDK-to-8.41.0 to main December 12, 2024 16:20
krystofwoldrich
krystofwoldrich reviewed Dec 12, 2024
View reviewed changes
scripts/update-javascript.sh Outdated
packages=('@sentry/browser' '@sentry/core' '@sentry/react' '@sentry/types' '@sentry/utils' '@sentry-internal/typescript')
packages=('@sentry/browser' '@sentry/core' '@sentry/react' '@sentry/types' '@sentry-internal/typescript')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package will be deprecated but present until v9, and so we should keep updating it.

@krystofwoldrich krystofwoldrich merged commit 98fb43f into main Dec 12, 2024
56 checks passed
@krystofwoldrich krystofwoldrich deleted the antonis/deprecate-sentry-utils branch December 12, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich left review comments

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate @sentry/utils
3 participants
@antonis @lucas-zimerman @krystofwoldrich