Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): Disable HTTP Client errors in sentry-cocoa to avoid duplicates #4347

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix(ios): Disable HTTP Client errors in sentry-cocoa to avoid duplicates #4347

merged 2 commits into from
Dec 11, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Dec 6, 2024 •
edited
Loading

📢 Type of change

  • Bugfix

📜 Description

💚 How did you test it?

native tests, sample app

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 443.76 ms 424.96 ms -18.80 ms
Size 17.74 MiB 20.09 MiB 2.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2b64fe 316.88 ms 330.23 ms 13.35 ms
c2a4e9b 480.42 ms 485.60 ms 5.18 ms
690220d 468.28 ms 480.06 ms 11.78 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
0db0c72 372.12 ms 386.00 ms 13.88 ms
484813b 434.55 ms 452.31 ms 17.75 ms
148f924 492.65 ms 500.28 ms 7.63 ms
c639edf 466.48 ms 489.57 ms 23.09 ms
7fd512a 442.18 ms 437.57 ms -4.61 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms

App size

Revision Plain With Sentry Diff
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
c2a4e9b 17.73 MiB 20.06 MiB 2.33 MiB
690220d 17.74 MiB 20.08 MiB 2.35 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
0db0c72 17.73 MiB 19.75 MiB 2.02 MiB
484813b 17.73 MiB 20.07 MiB 2.33 MiB
148f924 17.73 MiB 19.94 MiB 2.21 MiB
c639edf 17.74 MiB 20.08 MiB 2.34 MiB
7fd512a 17.74 MiB 20.08 MiB 2.35 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB

Previous results on branch: kw/fix-http-client-error-ios

Startup times

Revision Plain With Sentry Diff
69e3e67 434.22 ms 422.84 ms -11.38 ms

App size

Revision Plain With Sentry Diff
69e3e67 17.74 MiB 20.09 MiB 2.35 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 469.46 ms 463.44 ms -6.02 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4a6664f+dirty 357.02 ms 394.91 ms 37.89 ms
22e31b6+dirty 295.75 ms 346.73 ms 50.98 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
7fd512a+dirty 439.69 ms 503.71 ms 64.01 ms
8de2810+dirty 368.43 ms 412.20 ms 43.77 ms
d361d38+dirty 257.72 ms 318.76 ms 61.04 ms
52c0562+dirty 401.23 ms 435.65 ms 34.42 ms
148f924+dirty 347.36 ms 389.13 ms 41.77 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
7bc4d75+dirty 420.96 ms 472.25 ms 51.29 ms

App size

Revision Plain With Sentry Diff
4a6664f+dirty 7.15 MiB 8.22 MiB 1.07 MiB
22e31b6+dirty 7.15 MiB 8.10 MiB 981.29 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
7fd512a+dirty 7.15 MiB 8.35 MiB 1.21 MiB
8de2810+dirty 7.15 MiB 8.35 MiB 1.20 MiB
d361d38+dirty 7.15 MiB 8.08 MiB 959.34 KiB
52c0562+dirty 7.15 MiB 8.39 MiB 1.24 MiB
148f924+dirty 7.15 MiB 8.21 MiB 1.07 MiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
7bc4d75+dirty 7.15 MiB 8.35 MiB 1.20 MiB

Previous results on branch: kw/fix-http-client-error-ios

Startup times

Revision Plain With Sentry Diff
69e3e67+dirty 631.13 ms 687.80 ms 56.67 ms

App size

Revision Plain With Sentry Diff
69e3e67+dirty 7.15 MiB 8.37 MiB 1.22 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.04 ms 1234.06 ms 6.02 ms
Size 2.36 MiB 3.11 MiB 759.87 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c639edf+dirty 1236.18 ms 1235.04 ms -1.14 ms
b8ff156+dirty 1236.51 ms 1234.53 ms -1.98 ms
484813b+dirty 1222.45 ms 1220.79 ms -1.66 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
77680ec+dirty 1231.81 ms 1238.35 ms 6.54 ms
0677344+dirty 1276.70 ms 1300.07 ms 23.37 ms
63ed251+dirty 1232.55 ms 1238.77 ms 6.22 ms
8c88ac7+dirty 1205.13 ms 1218.87 ms 13.74 ms
5446992+dirty 1273.28 ms 1276.68 ms 3.40 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms

App size

Revision Plain With Sentry Diff
c639edf+dirty 2.36 MiB 3.08 MiB 736.63 KiB
b8ff156+dirty 2.36 MiB 3.11 MiB 759.80 KiB
484813b+dirty 2.36 MiB 3.08 MiB 734.18 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
77680ec+dirty 2.36 MiB 3.10 MiB 753.42 KiB
0677344+dirty 2.36 MiB 2.85 MiB 496.81 KiB
63ed251+dirty 2.36 MiB 3.10 MiB 752.55 KiB
8c88ac7+dirty 2.36 MiB 3.10 MiB 752.63 KiB
5446992+dirty 2.36 MiB 2.88 MiB 531.94 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB

Previous results on branch: kw/fix-http-client-error-ios

Startup times

Revision Plain With Sentry Diff
69e3e67+dirty 1233.53 ms 1237.06 ms 3.53 ms

App size

Revision Plain With Sentry Diff
69e3e67+dirty 2.36 MiB 3.11 MiB 759.84 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.51 ms 1246.55 ms 9.04 ms
Size 2.92 MiB 3.67 MiB 772.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c639edf+dirty 1223.63 ms 1227.98 ms 4.35 ms
b8ff156+dirty 1238.92 ms 1239.57 ms 0.66 ms
484813b+dirty 1225.07 ms 1221.00 ms -4.07 ms
12427f4+dirty 1224.90 ms 1231.40 ms 6.50 ms
77680ec+dirty 1237.65 ms 1236.24 ms -1.41 ms
0677344+dirty 1252.52 ms 1254.08 ms 1.56 ms
63ed251+dirty 1223.27 ms 1222.94 ms -0.33 ms
8c88ac7+dirty 1240.66 ms 1247.42 ms 6.76 ms
5446992+dirty 1249.94 ms 1254.80 ms 4.86 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms

App size

Revision Plain With Sentry Diff
c639edf+dirty 2.92 MiB 3.64 MiB 742.55 KiB
b8ff156+dirty 2.92 MiB 3.67 MiB 772.38 KiB
484813b+dirty 2.92 MiB 3.64 MiB 740.56 KiB
12427f4+dirty 2.92 MiB 3.44 MiB 533.29 KiB
77680ec+dirty 2.92 MiB 3.66 MiB 758.54 KiB
0677344+dirty 2.92 MiB 3.41 MiB 500.94 KiB
63ed251+dirty 2.92 MiB 3.66 MiB 757.10 KiB
8c88ac7+dirty 2.92 MiB 3.66 MiB 757.12 KiB
5446992+dirty 2.92 MiB 3.44 MiB 535.26 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB

Previous results on branch: kw/fix-http-client-error-ios

Startup times

Revision Plain With Sentry Diff
69e3e67+dirty 1244.50 ms 1248.67 ms 4.17 ms

App size

Revision Plain With Sentry Diff
69e3e67+dirty 2.92 MiB 3.67 MiB 772.34 KiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review December 10, 2024 12:10
antonis
antonis approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thank you for adding a test 🙇

@antonis antonis merged commit 9385d74 into main Dec 11, 2024
62 checks passed
@antonis antonis deleted the kw/fix-http-client-error-ios branch December 11, 2024 08:23
@antonis antonis mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabling enableCaptureFailedRequests does not work for iOS
2 participants
@krystofwoldrich @antonis