Export Span
type for using startInactiveSpan
#4345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Export the
Span
type so projects can use it.💡 Motivation and Context
When working with
startInactiveSpan
, I've been writing some utilities to make managing spans easier across separate scopes (e.g., starting a span when a user clicks a button, and ending it when a loading spinner stops, which are in totally separate components. I'd also like to use this to make it easier to usewithActiveSpan
when I want.)When doing this I noticed the type for
Span
was not exported, which I needed to type arguments for my utilities.💚 How did you test it?
I made the same change in the project I'm working on.
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps
Hopefully this one is straightforward and this is it 😄 let me know if you have any questions!