Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
_serialize_span_attribute
, it's not guaranteed that the same kind of object will be serialized the same way. E.g. lists are sometimes serialized as lists (if they only contain one element type) but can also be serialized as strings. This makes for a really bad user interface. So just usestr
everywhere when dealing with serializing task queueargs
andkwargs
.args
,kwargs
Sometimes we were just silencing errors with
try...except
. In cases where this can legitimately be an SDK issue, usecapture_internal_exceptions
instead.GH research shows some folks use headers to make sampling decisions. Add headers to span attributes.
Closes #3746