Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler sampling context #3840

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Dec 3, 2024

  • create a convenience func to generate sampling_context for both spans and profiles
  • generate sampling_context for profiles in span processor and use it in profiles_sampler

Closes #3793

Copy link

codecov bot commented Dec 3, 2024

❌ 837 Tests Failed:

Tests completed Failed Passed Skipped
19107 837 18270 4424
View the top 2 failed tests by shortest run time
tests.integrations.threading.test_threading test_propagates_hub[False]
Stack Traces | 0.007s run time
.../integrations/threading/test_threading.py:71: in test_propagates_hub
    assert "stage1" not in event.get("tags", {})
E   AssertionError: assert 'stage1' not in {'stage1': 'true'}
E    +  where {'stage1': 'true'} = <built-in method get of dict object at 0x7f673cd7d840>('tags', {})
E    +    where <built-in method get of dict object at 0x7f673cd7d840> = {'breadcrumbs': {'values': []}, 'contexts': {'trace': {'parent_span_id': None, 'span_id': '991e1accdccf4793', 'trace_id': 'f422f3f878064f1b85f8e9037cf2142f'}}, 'environment': 'production', 'event_id': '0b2b3e981f994392b4aa8964c3d1d557', ...}.get
tests.integrations.threading.test_threading test_propagates_hub[False]
Stack Traces | 0.008s run time
.../integrations/threading/test_threading.py:71: in test_propagates_hub
    assert "stage1" not in event.get("tags", {})
E   AssertionError: assert 'stage1' not in {'stage1': 'true'}
E    +  where {'stage1': 'true'} = <built-in method get of dict object at 0x7f63c49da380>('tags', {})
E    +    where <built-in method get of dict object at 0x7f63c49da380> = {'breadcrumbs': {'values': []}, 'contexts': {'trace': {'parent_span_id': None, 'span_id': 'a72729abc358bfd7', 'trace_id': 'c08c83e4363a41a39cf06621aecca903'}}, 'environment': 'production', 'event_id': '9252457f20a04d8585105f2cdc1855b2', ...}.get
View the full list of 1 ❄️ flaky tests
tests.integrations.threading.test_threading test_propagates_hub[False]

Flake rate in main: 99.27% (Passed 2 times, Failed 273 times)

Stack Traces | 0.007s run time
.../integrations/threading/test_threading.py:71: in test_propagates_hub
    assert "stage1" not in event.get("tags", {})
E   AssertionError: assert 'stage1' not in {'stage1': 'true'}
E    +  where {'stage1': 'true'} = <built-in method get of dict object at 0x7f780c307480>('tags', {})
E    +    where <built-in method get of dict object at 0x7f780c307480> = {'breadcrumbs': {'values': []}, 'contexts': {'trace': {'parent_span_id': None, 'span_id': '87dd054a358ec1e6', 'trace_id': '8a6caa1222914085acb856fc75b064a8'}}, 'environment': 'production', 'event_id': 'e8d76460ff1e4badbaa78cf8e99005aa', ...}.get

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@sentrivana sentrivana marked this pull request as ready for review December 3, 2024 13:21
@sentrivana sentrivana merged commit de7e58b into potel-base Dec 3, 2024
58 of 125 checks passed
@sentrivana sentrivana deleted the ivana/potel/sampling-context-profiler branch December 3, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants