Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #3834

Merged
merged 11 commits into from
Dec 2, 2024
Merged

Fix CI #3834

merged 11 commits into from
Dec 2, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Dec 2, 2024 •
edited
Loading

The latest release of httpx seems to have broken the test clients of some older versions of Litestar, Starlite, Anthropic, Langchain, OpenAI, Starlette.

Pinning httpx for old versions.

Also tweaking what versions to test against.

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
15166 1 15165 4383
View the top 1 failed tests by shortest run time 
tests.integrations.stdlib.test_httplib test_http_timeout
Stack Traces | 60.2s run time 
.../integrations/stdlib/test_httplib.py:373: in test_http_timeout
    assert len(transaction["spans"]) == 1
E   assert 6 == 1
E     +6
E     -1

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@sentrivana sentrivana changed the title Fix litestar tests Fix CI Dec 2, 2024
@sentrivana sentrivana marked this pull request as ready for review December 2, 2024 08:54
@sentrivana sentrivana marked this pull request as draft December 2, 2024 09:20
@sentrivana sentrivana marked this pull request as ready for review December 2, 2024 09:42
antonpirker
antonpirker approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning that up!

@sentrivana sentrivana merged commit e7130e8 into master Dec 2, 2024
136 checks passed
@sentrivana sentrivana deleted the ivana/fix-litestar-tests branch December 2, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

@sl0thentr0py sl0thentr0py Awaiting requested review from sl0thentr0py

@szokeasaurusrex szokeasaurusrex Awaiting requested review from szokeasaurusrex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @antonpirker