Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set attribute if value is None #3816

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Don't set attribute if value is None #3816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions sentry_sdk/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1329,8 +1329,7 @@ def description(self, value):
# type: (Optional[str]) -> None
from sentry_sdk.integrations.opentelemetry.consts import SentrySpanAttribute

if value is not None:
self.set_attribute(SentrySpanAttribute.DESCRIPTION, value)
self.set_attribute(SentrySpanAttribute.DESCRIPTION, value)

@property
def origin(self):
Expand All @@ -1344,8 +1343,7 @@ def origin(self, value):
# type: (Optional[str]) -> None
from sentry_sdk.integrations.opentelemetry.consts import SentrySpanAttribute

if value is not None:
self.set_attribute(SentrySpanAttribute.ORIGIN, value)
self.set_attribute(SentrySpanAttribute.ORIGIN, value)

@property
def containing_transaction(self):
Expand Down Expand Up @@ -1435,8 +1433,7 @@ def op(self, value):
# type: (Optional[str]) -> None
from sentry_sdk.integrations.opentelemetry.consts import SentrySpanAttribute

if value is not None:
self.set_attribute(SentrySpanAttribute.OP, value)
self.set_attribute(SentrySpanAttribute.OP, value)

@property
def name(self):
Expand All @@ -1450,8 +1447,7 @@ def name(self, value):
# type: (Optional[str]) -> None
from sentry_sdk.integrations.opentelemetry.consts import SentrySpanAttribute

if value is not None:
self.set_attribute(SentrySpanAttribute.NAME, value)
self.set_attribute(SentrySpanAttribute.NAME, value)

@property
def source(self):
Expand Down Expand Up @@ -1573,6 +1569,11 @@ def get_attribute(self, name):

def set_attribute(self, key, value):
# type: (str, Any) -> None
if value is None:
# otel doesn't support None as values, preferring to not set the key
# at all instead
return

self._otel_span.set_attribute(key, _serialize_span_attribute(value))

def set_status(self, status):
Expand Down
Loading