feat(otel): Autoinstrumentation skeleton #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
approved these changes
Jun 25, 2024
It's not really meant to be used/doesn't really have value outside of the SDK so I wouldn't |
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
Expand the POTel PoC's autoinstrumentation capabilities. This change allows us to: - install and enable all available instrumentations by default - further configure instrumentations that accept optional arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the POTel PoC's autoinstrumentation capabilities.
This change allows us to:
Cleaned up the code a bit too, packed things into a distro, which doesn't really have much effect for us since we're not advertising it as such in
setup.pyto be used outside of the SDK, but it makes it look a bit better.Closes #3121
Some observations regarding this:
_load_instrumentorsby ourselves. This would allow us to bypass OTel's version/env var checking if we have a good reason for that. (E.g., enabling an instrumentation for a higher version of a framework that is not supported in the latest upstream release, etc. We should anyway contribute the version support upstream, but in case we don't want to wait for a release, this is one way to go about it.)