Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django channels AsgiHandler has been deprecated some time ago. #3141

Closed
wants to merge 2 commits into from
Closed

Django channels AsgiHandler has been deprecated some time ago. #3141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b5cfba
Since Django 3 the channels handler is deprecated
antonpirker Jun 7, 2024
e5f590a
Merge branch 'master' into antonpirker/django-fix-asgihandler-import
antonpirker Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sentry_sdk/integrations/django/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,10 +321,14 @@ def sentry_patched_drf_initial(self, request, *args, **kwargs):
def _patch_channels():
# type: () -> None
try:
# Django < 3.0
from channels.http import AsgiHandler # type: ignore
except ImportError:
return

try:
# DJango 3.0+
from django.core.handlers.asgi import ASGIHandler as AsgiHandler
except ImportError:
return
if not HAS_REAL_CONTEXTVARS:
# We better have contextvars or we're going to leak state between
# requests.
Expand Down
Loading