Skip to content

Commit

Permalink
ref(metrics): Update type hints for tag values
Browse files Browse the repository at this point in the history
Remove None, Tuple, and List from the MetricTagValue type as these are not supported and might confuse the user
  • Loading branch information
Elias Ram committed Jun 11, 2024
1 parent 6a9d152 commit 3d22c5d
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions sentry_sdk/_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
from typing import Any
from typing import Callable
from typing import Dict
from typing import List
from typing import Mapping
from typing import NotRequired
from typing import Optional
Expand Down Expand Up @@ -173,14 +172,7 @@
MetricTagsInternal = Tuple[Tuple[str, str], ...]

# External representation of tags as a dictionary.
MetricTagValue = Union[
str,
int,
float,
None,
List[Union[int, str, float, None]],
Tuple[Union[int, str, float, None], ...],
]
MetricTagValue = Union[str, int, float, None]
MetricTags = Mapping[str, MetricTagValue]

# Value inside the generator for the metric value.
Expand Down

0 comments on commit 3d22c5d

Please sign in to comment.