Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow ignoring minidumps from specific processes #1050

Closed
wants to merge 10 commits into from

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jan 9, 2025

Adds a feature to sentryMinidumpIntegration that allows you to ignore/skip minidumps from specific processes:

import * as Sentry from '@sentry/electron/main';

Sentry.init({
  dsn: '__DSN__',
  integrations: [sentryMinidumpIntegration({ ignoredProcesses: ['GPU', 'utility', 'unknown'] })],
});

Ignored minidumps will no longer impact the crash free session rate.

This PR also adds tests for:

  • Electron utility process crash
  • child_process.fork Node process crash
  • child_process.exec executable crash

Not all platforms can capture child process crashes:

event.process macOS Windows Linux
Electron utilityProcess utility 1
child_process.fork node
child_process.exec unknown
  • 1 Not working with v29.4.6. Possibly an Electron bug that won't get fixed because v29 is already EOL.

@timfish
Copy link
Collaborator Author

timfish commented Jan 10, 2025

It looks like the Electron Utility process crash doesn't result in a minidump on Ubuntu for Electron v29.4.6!

@timfish timfish marked this pull request as draft January 20, 2025 11:26
@timfish
Copy link
Collaborator Author

timfish commented Jan 21, 2025

Rather than merge this PR, I'm fixing beforeSend so that returning null does not impact release health.

@timfish timfish closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant