Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Scrubbing HTTP Data from HTTP Spans #12026

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

philipphofmann
Copy link
Member

DESCRIBE YOUR PR

Explain that most SDKs will add the HTTP query string and fragment as a data attribute to spans, as pointed out in the develop docs.

Related to #12025.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Explain that most SDKs will add the HTTP query string and fragment as a
data attribute to spans.
@philipphofmann philipphofmann requested a review from a team December 3, 2024 13:33
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs 🛑 Canceled (Inspect) Dec 12, 2024 10:01am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 10:01am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 10:01am

Copy link

codecov bot commented Dec 3, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.2MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.11MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!!

@philipphofmann philipphofmann enabled auto-merge (squash) December 12, 2024 09:36
@philipphofmann philipphofmann merged commit a1b93e2 into master Dec 12, 2024
11 checks passed
@philipphofmann philipphofmann deleted the feat/span-http-data-scrubbing branch December 12, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants