feat(angular): Update SDK provider setup docs for Angular 19 #11921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Lms24
changed the title
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
lforst
approved these changes
Nov 27, 2024
Comment on lines
+104
to
+106
| provideAppInitializer(() => { | ||
| inject(TraceService); | ||
| }), |
There was a problem hiding this comment.
Isn't this like a really sick API for us? Nice.
There was a problem hiding this comment.
It's quite neat but I don't think we can add many other things to it for now. SDK initialization for example still happens before the entire angular app is bootstrapped.
martinhaintz
pushed a commit
that referenced
this pull request
Nov 27, 2024
…ierarchy * master: (28 commits) feat(angular): Update SDK provider setup for Angular 19 (#11921) feat(dynamic-sampling): adapt docs to new dynamic sampling logic (#11886) update banner for post-launch week promotion (#11964) chore(android): Add masking options to AndroidManifest (#11863) Bump API schema to 2126f7dd (#11965) chore(Profiling): Add callouts and links to Android Profiling troubleshooting info (#11905) docs(flutter): Use sentry flutter init in samples (#11858) use native crypto to generate uuid (#11959) fix vercel integration 404 (#11958) Add RN Replay Privacy page (#11798) feat(dashboards): Add docs for Dashboard Edit Access Selector (#11822) feat(app-starts): Add RN SDK min version (#11650) feat(realy): Add Relay best practices guide (#11914) docs(sdks): New Scope APIs (#11943) docs(sdks): Span Sampling (#11940) Add include explaining sample code options (#11866) devenv: internal troubleshooting (#11947) Bump API schema to 0b18bfae (#11946) Bump API schema to 2bee5317 (#11945) feat: Link to Replay Issues when we mention Perf Issues as well (#11933) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
This PR updates the Angular provider setup in the Angular "Getting Started" docs page. In Angular 19, the
APP_INITIALIZERDI token was deprecated and the new recommended way to provide a dependency (ourTraceService) at app start is to useprovideAppInitializerand theinjectAPI.To be clear, this is not a breaking change. But it makes sense for us to document the most up to date way as well.
Also made a minor wording change in the compatibility note
Our SDK is comaptible with Angular 19 since v8.40.0, so this PR can be merged whenever it's approved.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES