Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dev console warnings #11916

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Clean up dev console warnings #11916

merged 3 commits into from
Nov 22, 2024

Conversation

a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Nov 22, 2024

fix issues behind some noise in the dev console like
1.

ReferenceError: module is not defined
    at file:///Users/abdellah/code/sentry-docs/tailwind.config.js:14:1
    at ModuleJobSync.runSync (node:internal/modules/esm/module_job:367:35)
    at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:325:47)
    at loadESMFromCJS (node:internal/modules/cjs/loader:1396:24)
    at Module._compile (node:internal/modules/cjs/loader:1529:5)
    at Object..js (node:internal/modules/cjs/loader:1709:10)
    at Module.load (node:internal/modules/cjs/loader:1315:32)
    at Function._load (node:internal/modules/cjs/loader:1125:12)
  1. <a> usage instead of next/link

  2. the annoying punnycode deprecation warning

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 0:34am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 0:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 0:34am

@a-hariti a-hariti requested a review from chargome November 22, 2024 12:05
Copy link

codecov bot commented Nov 22, 2024

Bundle Report

Changes will increase total bundle size by 133 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.13MB 65 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.02MB 68 bytes (0.0%) ⬆️

@a-hariti a-hariti changed the title Esm TailwindCSS config Clean up dev console warnings Nov 22, 2024
@a-hariti a-hariti merged commit ceb41bb into master Nov 22, 2024
13 checks passed
@a-hariti a-hariti deleted the esm-tw-config branch November 22, 2024 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants