feat(js): Add docs for updateSpanName
#11824
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Lms24
force-pushed
the
lms/feat-updateSpanName
branch
from
f7cbbe7 to
99ec67e
Compare
Bundle ReportChanges will increase total bundle size by 255.64kB (1.28%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
coolguyzone
reviewed
Nov 15, 2024
docs/platforms/javascript/common/tracing/instrumentation/custom-instrumentation/index.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Nov 15, 2024
docs/platforms/javascript/common/tracing/instrumentation/custom-instrumentation/index.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
approved these changes
Nov 15, 2024
docs/platforms/javascript/common/tracing/instrumentation/custom-instrumentation/index.mdx
Outdated
Show resolved
Hide resolved
lizokm
approved these changes
Nov 18, 2024
docs/platforms/javascript/common/tracing/instrumentation/custom-instrumentation/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/tracing/instrumentation/custom-instrumentation/index.mdx
Outdated
Show resolved
Hide resolved
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
3 tasks
Lms24
force-pushed
the
lms/feat-updateSpanName
branch
from
99ec67e to
e5d3f66
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
To be merged only once getsentry/sentry-javascript#14291 was released
This PR:
Sentry.updateSpanName, a helper function we (unfortunately) had to add to the JS SDKspan.updateNamedocumentation, leaving the shortcomings of the previous way to update a span name in Node in place@sentry/react) to continue usingspan.updateName. Happy to change this if reviewers have different opinionsIS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES