Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(flutter): Document Flutter web limitations #10474

Merged
merged 11 commits into from
Jun 27, 2024

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jun 24, 2024

DESCRIBE YOUR PR

Add some Flutter web limitations to the features page.

Based on getsentry/sentry-dart#897
Relates to #4312

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Jun 24, 2024

@denrase is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@denrase denrase marked this pull request as draft June 24, 2024 15:50
@lizokm lizokm requested a review from buenaflor June 24, 2024 20:24
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 11:31am

@denrase denrase marked this pull request as ready for review June 25, 2024 09:32
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

docs/platforms/flutter/features/index.mdx Outdated Show resolved Hide resolved
docs/platforms/flutter/features/index.mdx Outdated Show resolved Hide resolved
@buenaflor buenaflor requested a review from kahest June 25, 2024 14:55
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some copyedits. Thanks for adding this!

docs/platforms/flutter/features/index.mdx Outdated Show resolved Hide resolved
docs/platforms/flutter/features/index.mdx Outdated Show resolved Hide resolved
docs/platforms/flutter/features/index.mdx Outdated Show resolved Hide resolved
docs/platforms/flutter/features/index.mdx Outdated Show resolved Hide resolved
docs/platforms/flutter/features/index.mdx Outdated Show resolved Hide resolved
@buenaflor buenaflor enabled auto-merge (squash) June 27, 2024 08:53
@buenaflor
Copy link
Contributor

we need a vercel preview run pls 🙏

@buenaflor buenaflor merged commit dfb6e59 into getsentry:master Jun 27, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants