ref(chunks): Remove upload-dif reference from poll_assemble
#2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has a huge diff, is that intentional? |
|
@loewenheim No, looks like there are some extra commits in here (the extra commits should be in the PRs that this change depends on). Might need to rebase and update some things. I'll ping you once I've fixed it |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-12a
branch
from
590f24d to
f6d2555
Compare
|
@loewenheim fixed it, thanks for pointing out the big diff! |
loewenheim
approved these changes
Dec 18, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-12
branch
from
e6f01fa to
27c7296
Compare
We should not mention `upload-dif` in this error message because (1) `upload-dif` is a soft-deprecated hidden alias to `debug-files upload` and (2) `poll_assemble` has now been generalized and could be used with other commands in the future. For reason (2), this change makes the error message general rather than referring to the `debug-files upload` command.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-12a
branch
from
f6d2555 to
3fd0566
Compare
Base automatically changed from
szokeasaurusrex/proguard-upload-12
to
master
December 18, 2024 13:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not mention
upload-difin this error message because (1)upload-difis a soft-deprecated hidden alias todebug-files uploadand (2)poll_assemblehas now been generalized and could be used with other commands in the future.For reason (2), this change makes the error message general rather than referring to the
debug-files uploadcommand.