ref(dif): Add ability to get server options from ChunkOptions
#2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-9
branch
from
f717d84 to
a661c6c
Compare
loewenheim
reviewed
Dec 5, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-8
branch
from
99e7bae to
2c576c0
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-9
branch
from
a661c6c to
6203e7a
Compare
loewenheim
approved these changes
Dec 5, 2024
|
No, that's fair. |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-8
branch
from
2c576c0 to
1d5d593
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-9
branch
from
6203e7a to
d923964
Compare
Owned string is not necesary here, and having it will make it harder to convert `DifUpload` into `ChunkOptions`
Previously, `ChunkOptions` was implemented as a trait, but we realized it makes more sense to have it be a struct, instead. Now, as a struct, we also have `ChunkOptions` store the `ChunkServerOptions`, which will eventually allow us to simplify some API's, since we can take `ChunkOptions` only, rather than `DIFUpload` and `ChunkServerOptions` for methods such as `upload_difs_chunked`.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-9
branch
from
d923964 to
cf02c17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to the
ChunkOptionstrait, allowing theChunkServerOptionsto be obtained. With this change,DifUploadcan no longer implementChunkOptionsdirectly, since it does not contain the server options, so we create a newChunkedDifUploadstruct to implementChunkOptionsby acting as a container for theDifUploadandChunkServerOptions.Also, we take advantage of the new functionality by refactoring
upload_difs_chunkedto take only a single argument, theChunkedDifUpload. The upload methods now take owned options structs, since an upload should only be performed once.