feat(debugid): Update debug ID snippet to write on globalThis when available
#2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
@lforst This is not a breaking change, correct?
If it is not, then I think we can merge this (although maybe someone more familiar with JS should also review).
I think this change should also address the concerns raised by @JakeShirley on #2162
|
Correct, this is not a breaking change. Tagging @Lms24 for a review. |
Lms24
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to getsentry/sentry-javascript-bundler-plugins#636 we want to write debug IDs to
globalThisfor runtimes that do not support the other global objects.