ref(dif): Make try_assemble_dif generic
#2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Nov 29, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/refactor-chunk-upload-dif
branch
from
93897c3 to
c2c893d
Compare
Now, `try_assemble_dif` can take arbitrary chunked objects (as long as we have a way to convert them into a `ChunkedDifRequest`). ref #2195
szokeasaurusrex
force-pushed
the
szokeasaurusrex/refactor-try_assemble_dif
branch
from
748d28d to
1ca5259
Compare
Base automatically changed from
szokeasaurusrex/refactor-chunk-upload-dif
to
master
November 29, 2024 13:24
szokeasaurusrex
deleted the
szokeasaurusrex/refactor-try_assemble_dif
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now,
try_assemble_difcan take arbitrary chunked objects (as long as we have a way to convert them into aChunkedDifRequest).ref #2195