ref(dif): Replace ChunkedDifMatch with generic ChunkedObject
#2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Nov 29, 2024
Base automatically changed from
szokeasaurusrex/refactor-get_sha1_checksums
to
master
November 29, 2024 12:45
So that we can reuse the code for chunk uploading difs for other file types as well, replace the `ChunkedDifMatch` struct with a similar, generic type called `ChunkedObject`. The code path is not fully generic yet, but it is a step in the right direction. ref #2195
szokeasaurusrex
force-pushed
the
szokeasaurusrex/refactor-chunk-upload-dif
branch
from
93897c3 to
c2c893d
Compare
loewenheim
approved these changes
Nov 29, 2024
szokeasaurusrex
deleted the
szokeasaurusrex/refactor-chunk-upload-dif
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can reuse the code for chunk uploading difs for other file types as well, replace the
ChunkedDifMatchstruct with a similar, generic type calledChunkedObject.The code path is not fully generic yet, but it is a step in the right direction.
ref #2195