feat(crons): New monitor configuration options (#1922)

This PR adds the --failure-issue-threshold and --recovery-threshold command line arguments. These control the number of consecutive failed cron checkins that trigger issue creation, and the number of consecutive successful cron checkins that trigger issue resolution, respectively.

Fixes GH-1919

Cargo.toml

@@ -58,7 +58,7 @@ regex = "1.7.3"
 runas = "1.0.0"
 rust-ini = "0.18.0"
 semver = "1.0.16"
-sentry = { version = "0.31.8", default-features = false, features = [
+sentry = { version = "0.32.2", default-features = false, features = [
   "anyhow",
   "curl",
   "contexts",

src/commands/monitors/run.rs

@@ -87,6 +87,26 @@ pub fn make_command(command: Command) -> Command {
                     execution schedule's timezone. Requires --schedule.",
                 ),
         )
+        .arg(
+            Arg::new("failure_issue_threshold")
+                .long("failure-issue-threshold")
+                .value_parser(clap::value_parser!(u64).range(1..))
+                .requires("schedule")
+                .help(
+                    "The number of consecutive missed or error check-ins that trigger an \
+                     issue. Requires --schedule.",
+                ),
+        )
+        .arg(
+            Arg::new("recovery_threshold")
+                .long("recovery-threshold")
+                .value_parser(clap::value_parser!(u64).range(1..))
+                .requires("schedule")
+                .help(
+                    "The number of consecutive successful check-ins that resolve an \
+                     issue. Requires --schedule.",
+                ),
+        )
 }
 
 fn run_program(args: Vec<&String>, monitor_slug: &str) -> (bool, Option<i32>, Duration) {
@@ -211,6 +231,8 @@ fn parse_monitor_config_args(matches: &ArgMatches) -> Result<Option<MonitorConfi
         checkin_margin: matches.get_one("checkin_margin").copied(),
         max_runtime: matches.get_one("max_runtime").copied(),
         timezone: matches.get_one("timezone").map(Tz::to_string),
+        failure_issue_threshold: matches.get_one("failure_issue_threshold").copied(),
+        recovery_threshold: matches.get_one("recovery_threshold").copied(),
     }))
 }
 

tests/integration/_cases/monitors/monitors-run-help.trycmd

@@ -34,6 +34,11 @@ Options:
       --timezone <timezone>
           A tz database string (e.g. "Europe/Vienna") representing the monitor's execution
           schedule's timezone. Requires --schedule.
+      --failure-issue-threshold <failure_issue_threshold>
+          The number of consecutive missed or error check-ins that trigger an issue. Requires
+          --schedule.
+      --recovery-threshold <recovery_threshold>
+          The number of consecutive successful check-ins that resolve an issue. Requires --schedule.
   -h, --help
           Print help