Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Read debug IDs from debugId field #97

Merged
merged 2 commits into from
Nov 6, 2024
Merged

feat: Read debug IDs from debugId field #97

merged 2 commits into from
Nov 6, 2024

Conversation

loewenheim
Copy link
Contributor

This partially implements #96. The debug id will still be serialized as "debug_id", but can now additionally be read from "debugId".

@loewenheim loewenheim requested a review from a team November 6, 2024 15:14
@loewenheim loewenheim requested a review from lforst November 6, 2024 15:16
@loewenheim loewenheim self-assigned this Nov 6, 2024
loewenheim added a commit to getsentry/symbolic that referenced this pull request Nov 6, 2024
Companion PR to getsentry/rust-sourcemap#97.
This adjusts `discover_sourcemap_embedded_debug_id` so that
it finds debug IDs at both `"debug_id"` and `"debugId"`.
loewenheim added a commit to getsentry/symbolic that referenced this pull request Nov 6, 2024
Companion PR to getsentry/rust-sourcemap#97.
This adjusts `discover_sourcemap_embedded_debug_id` so that
it finds debug IDs at both `"debug_id"` and `"debugId"`.
@loewenheim loewenheim merged commit 5596603 into master Nov 6, 2024
6 checks passed
@loewenheim loewenheim deleted the feat/debugId branch November 6, 2024 16:15
loewenheim added a commit to getsentry/sentry-cli that referenced this pull request Nov 7, 2024
This is accomplished by updating `symbolic` and `rust-sourcemap`. See
getsentry/symbolic#874 and
getsentry/rust-sourcemap#97.

Closes #2220.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants