fix: Resolve conflict between "debugId" and "debug_id" #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Nov 26, 2024
Dav1dde
approved these changes
Nov 26, 2024
src/jsontypes.rs
Outdated
| pub debug_id: Option<DebugId>, | ||
| // This field only exists to be able to deserialize from "debug_id" keys | ||
| // if "debugId" is unset. | ||
| #[serde(skip_serializing, rename = "debug_id")] |
There was a problem hiding this comment.
This may be a problem when deserializing and immediately serializing again.
There was a problem hiding this comment.
Good catch. skip_serializing_if should take care of that.
Merged
loewenheim
added a commit
that referenced
this pull request
Nov 26, 2024
#100 overzealously switched the default key from debug_id to debugId. While both should be supported, we should default to the current debug_id for now and make the switch in a considered manner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an alias produces an error when both fields are set. The intended behavior is to only read from
"debug_id"if"debugId"is not present. We now encode this logic explicitly by deserializing both and choosing manually.