Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn debug_id field to debugId #96

Open
lforst opened this issue Nov 5, 2024 · 2 comments
Open

Turn debug_id field to debugId #96

lforst opened this issue Nov 5, 2024 · 2 comments

Comments

@lforst
Copy link
Member

lforst commented Nov 5, 2024

The relevant TC39 proposal proposes debug IDs to be in camelCase (debugId): https://github.com/tc39/source-map/blob/8be0fe10ad042e13f4196d17b44ddedfd6a9df58/proposals/debug-id.md?plain=1#L111

We probably need to figure out some sort of migration path or cut a major for this?

@loewenheim
Copy link
Contributor

At least for parsing/deserialization this shouldn't be a problem—we can change the serialized field name to debugId and keep debug_id as a serde::alias so it can still be read. But I guess it would still count as a breaking change because serialization behavior changes.

@lforst
Copy link
Member Author

lforst commented Nov 5, 2024

At least for parsing/deserialization this shouldn't be a problem—we can change the serialized field name to debugId and keep debug_id as a serde::alias so it can still be read. But I guess it would still count as a breaking change because serialization behavior changes.

Fully agree. Versions are free so we should just be careful and do a major if we change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants