Update to upload-artifact@v4 in CI workflows

[justinclift]

What type of PR is this?

• Other

Description

This PR updates our CI workflows from actions/upload-artifact@v3 to actions/upload-artifact@v4. This is due to several of the workflows showing this warning during their runs:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js
20: actions/upload-artifact@v3.

For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

How is this tested?

• E2E Tests (Cypress)

It's passing our CI tests, so looks safe. 😄

[lucydodo]

https://github.com/actions/upload-artifact#breaking-changes
Uploading to the same named Artifact multiple times.

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

Starting with v4, artifact names cannot be duplicated. So we need to rename the artifact for each step.

[justinclift]

Interesting. That doesn't seem clear as to whether the unique artifact name is "per workflow" (eg backend-unit-tests, frontend-e2e-tests, etc), or per .yml file, or maybe something else. 🙄

That says it'll error out if there's a problem, and the CI run didn't seem to throw errors, so I wonder if we're ok?

[justinclift]

Seems to be more details here:

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact

The examples there shows what seems to be different jobs having the same artifact name (as we do), but in their examples it's throwing an error.

We're probably best off to play it safe and do the rename thing.

In that case, we'll probably need to update whatever is looking for the uploaded artifacts so it finds the new ones.

[lucydodo]

Based on my previous experience doing the same thing in other repo, it seems to be determined by a single action 'run'.
It other words, if the workflow are different but both are exeuted in one action 'run', they are considered duplicate.

https://github.com/getredash/redash/actions/runs/8592014265/job/23541482569?pr=6857
Store Test Results
Run actions/upload-artifact@v3

Additionally, the current CI for this PR is using the 'v3' version, so it doesn't seem to be throwing any errors.

[lucydodo]

In that case, we'll probably need to update whatever is looking for the uploaded artifacts so it finds the new ones.

Yes, I'd take a look, but I don't think I have access to 'Codecov' :(
Additionally, I resolved it last time simply by adding a suffix. ex) build-artifact to build-artifact-macos

[justinclift]

Yes, I'd take a look, but I don't think I have access to 'Codecov' :(

Oh. I think that should be fixable. 😄

I'd not personally tried it out before, apart from looking at the "Code Coverage" report things it generates as part of our standard CI workflow.

However, clicking on one of the existing Redash code coverage "Details" links (like this one) worked.

That took me to a page to create a codecov.io (using my GitHub login), then automatically figured out the project I was coming from.

Additionally, it seems to have a way of adding extra organisations too:

That's the "Add GitHub Organization" link in the drop down above.

Maybe try that and see if it works? 😄

[lucydodo]

I tried, but it still says I don't have permission. :(

[justinclift]

Try again now, I've just bumped up your permissions to admin level for this repo. Lets see if recognises that or not. 😄

[lucydodo]

That's weird, it still says it's not accessible.

[justinclift]

Ugh. That sounds like it's only going to recognise people who've been added via the main getredash organisation "team members" interface thing, and isn't recognising people who've been added as collaborators to specific repos. 😦

I'll email @arikfr directly to get that done (there's a queue already though). Pinging him via discord isn't working, but maybe email will. 😄

[lucydodo]

Okay, I'll be waiting :)

[justinclift]

Email sent. 😄

[justinclift]

Received a response from @arikfr via email. He said he's travelling at the moment, so will take care of this stuff in a few days.

[lucydodo]

No worries, this PR is not urgent at all. :)

[justinclift]

This PR isn't needed any more, as the update to upload-artifact@v4 was included in PR #6674 which has just been merged. 😄