Handle timedelta in query results #6846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinclift @eradman Another one to look at when you have a sec |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6846 +/- ##
=======================================
Coverage 63.50% 63.50%
=======================================
Files 163 163
Lines 13206 13209 +3
Branches 1824 1825 +1
=======================================
+ Hits 8386 8389 +3
Misses 4518 4518
Partials 302 302
|
|
@eradman Are you ok to look over this one? Looking over it, it seems super simple. 😁 |
eradman
approved these changes
Apr 3, 2024
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
(this is a follow-on to #6837)
Since #6687, we don't serialize query results as JSON before returning them. This is fine, except for the
query results data source which needs to pass the data directly to sqlite3, and doesn't know how to
do that with the timedelta types that are occasionally returned by (at least) the PostgreSQL query runner:
https://www.psycopg.org/docs/faq.html#problems-with-type-conversions
How is this tested?
Related Tickets & Documents
N/A
Mobile & Desktop Screenshots/Recordings (if there are UI changes)