-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RisingWave support #6776
Add RisingWave support #6776
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6776 +/- ##
==========================================
+ Coverage 63.41% 63.43% +0.01%
==========================================
Files 162 163 +1
Lines 13186 13200 +14
Branches 1822 1822
==========================================
+ Hits 8362 8373 +11
- Misses 4527 4530 +3
Partials 297 297
|
I believe that it is necessary to allocate RisingWave to a separate file |
You are right! |
Hi, i moved the code to its own file. Sadly now the data source is not showing up in the UI anymore. What am I missing? |
You need to add settings https://github.com/getredash/redash/blob/master/redash/settings/__init__.py#L341 @stefannegele |
@konnectr thanks for the hint! I just applied it, then tested, squashed, and rebased to upstream. Let me know if you need anything else for this to get accepted :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you! @stefannegele |
What type of PR is this?
Description
RisingWave (1.6.0) is a PostgreSQL compatible streaming database. This PR basically uses the PostgreSQL query runner but changes the listing of tables in two ways:
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)