Support multi column results with using mongo query runner #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: del-zhenwu <[email protected]>
update unit test case: nested dict for mongodb runner
guidopetri
changed the title
|
@justinclift would you kindly give me an approval on this since I can't do it myself (I'm the latest committer)? 😅 |
Codecov Report
@@ Coverage Diff @@
## master #6558 +/- ##
==========================================
- Coverage 61.90% 61.89% -0.01%
==========================================
Files 158 158
Lines 12966 12968 +2
Branches 1773 1772 -1
==========================================
Hits 8027 8027
- Misses 4664 4665 +1
- Partials 275 276 +1
|
justinclift
approved these changes
Oct 29, 2023
|
Just did the approve. |
|
Thanks mate :) |
|
@del-zhenwu thanks for these changes! |
spacentropy
added a commit
to dodopizza/redash
that referenced
this pull request
Jan 17, 2024
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
…#6558) * Support multi column results with using mongo query runner * format Signed-off-by: del-zhenwu <[email protected]> * Update test_mongodb.py update unit test case: nested dict for mongodb runner * Update test_mongodb.py * fix formatting --------- Signed-off-by: del-zhenwu <[email protected]> Co-authored-by: del-zhenwu <[email protected]> Co-authored-by: del-zhenwu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical contents to #6290 but with formatting fixes. I screwed up a rebase and accidentally closed the other PR irreversibly.